feat: passes sim result to the submit tasks #100
+140
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
4961bf7 to
df3f9a2
Compare
dylanlott
changed the base branch from
dylan/submit-channel-refactors
to
dylan/add-host-fills
dylanlott
force-pushed
the
dylan/add-host-fills
branch
2 times, most recently
from
f5c2178 to
a873d45
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
95a207e to
9a95da4
Compare
dylanlott
force-pushed
the
graphite-base/100
branch
from
a873d45 to
1fc9892
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
9a95da4 to
c2cd1ab
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
2 times, most recently
from
75b8d71 to
41019b6
Compare
dylanlott
force-pushed
the
dylan/chore-deps-sdk-main
branch
from
acf2569 to
2234717
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
2 times, most recently
from
501d86e to
92b1dde
Compare
dylanlott
changed the base branch from
dylan/chore-deps-sdk-main
to
prestwich/simrevert
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
2c09604 to
a96a88f
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
92b1dde to
b69451e
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
a96a88f to
aee1dd3
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
b69451e to
0f48d3e
Compare
dylanlott
force-pushed
the
prestwich/simrevert
branch
from
aee1dd3 to
da4a7fd
Compare
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
2 times, most recently
from
3432017 to
6fd3675
Compare
dylanlott
changed the title
- adds a SimResult type that binds a BlockEnv to a BuiltBlock - passess that SimResult to the SubmitTask for gas calculations
dylanlott
force-pushed
the
dylan/block-env-refactor
branch
from
54b51a6 to
3e2c5fa
Compare
prestwich
reviewed
Jun 10, 2025
prestwich
reviewed
Jun 10, 2025
prestwich
reviewed
Jun 10, 2025
prestwich
reviewed
Jun 10, 2025
prestwich
reviewed
Jun 10, 2025
| fn calculate_gas(retry_count: usize, block_env: &BlockEnv) -> (u128, u128, u128) { | ||
| let fallback_blob_basefee = 500; | ||
|
|
||
| match block_env.blob_excess_gas_and_price { |
There was a problem hiding this comment.
the block_env here is the Signet block env, not the host block env, no? it's constructed in EnvTask::construct_block_env and the blob excess gas and price will always be Some(0, 0).
using it to calculate the fee for the host transaction is a bug, as it contains no info about the host
There was a problem hiding this comment.
if you want the host blob gas (which is i think what you're looking for here) you'll need to make the env task's watch channel contain that alongside the constructed BlockEnv by maybe a
struct SimEnv {
signet: BlockEnv,
host: alloy::consensus::Header,
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Passes SimResult to the submit task
Closes ENG-1046
This PR adds a
SimResulttype that wraps aBuiltBlockand aBlockEnvtogether and sends them both to theSubmitTaskso that a block's environment is known at submission time for gas calculation purposes.SimResulttype that binds aBlockEnvto aBuiltBlockSimResultto theSubmitTaskfor gas calculation purposesBugfixes